[ https://issues.apache.org/jira/browse/SOLR-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316209#comment-16316209 ]
Amrit Sarkar commented on SOLR-11718: ------------------------------------- PFA updated SOLR-11718.patch which takes care for above: {{CdcrReplicationHandlerTest}} failures by simply removing them. The tests written for {{CdcrReplicationHandlerTest}} are specific for "source" cluster and verifies if the {{tlogs}} are getting copied over to follower nodes from leader when followers fail in b/w indexing, commits and etc. Since the {{CdcrReplicationHandlerTest}} was failing, suggesting typical Index Replication will take place when followers are numRecordsToKeep count behind. "target" cluster has nothing to do with it and is never referenced. [~varunthacker] this ready to ship with appropriate comments and documentation intact. > Deprecate CDCR Buffer APIs > -------------------------- > > Key: SOLR-11718 > URL: https://issues.apache.org/jira/browse/SOLR-11718 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: CDCR > Affects Versions: 7.1 > Reporter: Amrit Sarkar > Fix For: master (8.0), 7.3 > > Attachments: SOLR-11718.patch, SOLR-11718.patch > > > Kindly see the discussion on SOLR-11652. > Today, if we see the current CDCR documentation page, buffering is "disabled" > by default in both source and target. We don't see any purpose served by Cdcr > buffering and it is quite an overhead considering it can take a lot heap > space (tlogs ptr) and forever retention of tlogs on the disk when enabled. > Also today, even if we disable buffer from API on source , considering it was > enabled at startup, tlogs are never purged on leader node of shards of > source, refer jira: SOLR-11652 -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org