[ https://issues.apache.org/jira/browse/SOLR-11755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anshum Gupta updated SOLR-11755: -------------------------------- Attachment: SOLR-11175.patch Here's a patch that makes the constructor protected, allowing us to extend the V2Request class. [~noble.paul] what do you think? I've changed the constructor to be protected instead of public (as we discussed). P.S: This is after an offline discussion with Noble, where we agreed that making the constructor was the sensible/only way to be able to extend V2Request, which is required for new APIs that are v2 only. > Make V2Request constructor public > --------------------------------- > > Key: SOLR-11755 > URL: https://issues.apache.org/jira/browse/SOLR-11755 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Reporter: Anshum Gupta > Assignee: Anshum Gupta > Attachments: SOLR-11175.patch > > > V2Request has a private constructor that stops it from being extended. We > need to change the visibility for that constructor to protected or move the > shared methods out of that class into a common place so that SolrJ support > could be added for new V2 APIs. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org