[
https://issues.apache.org/jira/browse/SOLR-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16318349#comment-16318349
]
Andrzej Bialecki commented on SOLR-11714:
------------------------------------------
Ok, I see that now.
The logic in {{ComputePlanAction}} for handling {{searchRate}} events will end
up quite complex, due to the limitations of Suggester API (returning just one
op at a time) - eg. {{AddReplicaSuggester}} will need to be initialized
differently in each loop, otherwise it would keep adding replicas to the first
hot shard and ignore the others… For now this logic need to be put in
{{ComputePlanAction}} - but if we changed the {{Suggester.getSuggestion}} to be
able to return multiple suggestions, and changed
{{AddReplicaSuggester.getSuggestions()}} to return suggestions for all hints,
then we could move this complicated logic to {{SearchRateTrigger}}. WDYT?
> AddReplicaSuggester endless loop
> --------------------------------
>
> Key: SOLR-11714
> URL: https://issues.apache.org/jira/browse/SOLR-11714
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: AutoScaling
> Affects Versions: 7.2, master (8.0)
> Reporter: Andrzej Bialecki
> Assignee: Noble Paul
> Attachments: 7.2-disable-search-rate-trigger.diff, SOLR-11714.diff
>
>
> {{SearchRateTrigger}} events are processed by {{ComputePlanAction}} and
> depending on the condition either a MoveReplicaSuggester or
> AddReplicaSuggester is selected.
> When {{AddReplicaSuggester}} is selected there's currently a bug in master,
> due to an API change (Hint.COLL_SHARD should be used instead of Hint.COLL).
> However, after fixing that bug {{ComputePlanAction}} goes into an endless
> loop because the suggester endlessly keeps creating new operations.
> Please see the patch that fixes the Hint.COLL_SHARD issue and modifies the
> unit test to illustrate this failure.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
