[
https://issues.apache.org/jira/browse/SOLR-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hoss Man updated SOLR-3218:
---------------------------
Attachment: SOLR-3218.patch
I added some more {{json.facet}} tests, and dug into the {{Calc.bitsToValue}}
and {{Calc.bitsToSortableBits}} methods I couldn't make sense of before...
These methods exist solely for the use by {{FacetFieldProcessorByHashDV}} , and
would never be triggered for Currency fields because
{{FacetFieldProcessorByHashDV}} only uses these code paths if {{getNumberType()
!= null}} ... so for the purposes of {{type:reange}} faceting and/or {{field:
some_currency_field}} (regardless of the faceting type) these are in facet dead
code.
I added some general javadocs clarifying these methods for the next reader, and
replaced the {{RuntimeException("nocommit"))}} in the {{CurrencyCalc}}
instances of these methods with {{SERVER_ERRORs}} that should help make it
clear what's going wrong if someone breaks the code down the road.
I still want to write some more tests of some of the json.facet edge cases i'm
not super familiar with to make sure i'm not missing anything, but this should
resolve all of the open questions/confusion i had.
> Range faceting support for CurrencyField
> ----------------------------------------
>
> Key: SOLR-3218
> URL: https://issues.apache.org/jira/browse/SOLR-3218
> Project: Solr
> Issue Type: Improvement
> Components: Schema and Analysis
> Reporter: Jan Høydahl
> Assignee: Hoss Man
> Attachments: SOLR-3218-1.patch, SOLR-3218-2.patch, SOLR-3218.patch,
> SOLR-3218.patch, SOLR-3218.patch, SOLR-3218.patch, SOLR-3218.patch,
> SOLR-3218.patch, SOLR-3218.patch, SOLR-3218.patch, SOLR-3218.patch,
> SOLR-3218.patch
>
>
> Spinoff from SOLR-2202. Need to add range faceting capabilities for
> CurrencyField
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
