[ 
https://issues.apache.org/jira/browse/LUCENE-8121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322099#comment-16322099
 ] 

Jim Ferenczi commented on LUCENE-8121:
--------------------------------------

The expected score were correct, it's the frequency used to score the terms 
that was buggy. I pushed a fix that returns the expected frequency for a term 
that appears in a span query and the scores are the same as in the original 
commit now. I think it's just a missing change after optimizing some array 
resizing, [~dsmiley] ?

> UnifiedHighlighter can highlight terms within SpanNear clauses at unmatched 
> positions
> -------------------------------------------------------------------------------------
>
>                 Key: LUCENE-8121
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8121
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/highlighter
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Minor
>             Fix For: 7.3
>
>         Attachments: LUCENE-2287_UH_SpanCollector.patch, 
> LUCENE-2287_UH_SpanCollector.patch
>
>
> The UnifiedHighlighter (and original Highlighter) highlight phrases by 
> converting to a SpanQuery and using the Spans start and end positions to 
> assume that every occurrence of the underlying terms between those positions 
> are to be highlighted.  But this is inaccurate; see LUCENE-5455 for a good 
> example, and also LUCENE-2287.  The solution is to use the SpanCollector API 
> which was introduced after the phrase matching aspects of those highlighters 
> were developed. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to