Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/304#discussion_r161226045
--- Diff:
solr/core/src/java/org/apache/solr/handler/admin/CollectionsHandler.java ---
@@ -476,6 +451,31 @@ private static void
addStatusToResponse(NamedList<Object> results, RequestStatus
SolrIdentifierValidator.validateAliasName(req.getParams().get(NAME));
return req.getParams().required().getAll(null, NAME, "collections");
}),
+ CREATEROUTEDALIAS_OP(CREATEROUTEDALIAS, (req, rsp, h) -> {
+ String alias = req.getParams().get(NAME);
+ SolrIdentifierValidator.validateAliasName(alias);
+ Map<String, Object> params = req.getParams().required()
+ .getAll(null, REQUIRED_ROUTING_PARAMS.toArray(new
String[REQUIRED_ROUTING_PARAMS.size()]));
+ req.getParams().getAll(params, NONREQUIRED_ROUTING_PARAMS);
+ // subset the params to reuse the collection creation/parsing code
+ ModifiableSolrParams collectionParams =
extractPrefixedParams("create-collection.", req.getParams());
+ if (collectionParams.get(NAME) != null) {
+ SolrException solrException = new SolrException(BAD_REQUEST,
"routed aliases calculate names for their " +
+ "dependent collections, you cannot specify the name.");
+ log.error("Could not create routed alias",solrException);
+ throw solrException;
+ }
+ SolrParams v1Params = convertToV1WhenRequired(req, collectionParams);
+
+ // We need to add this temporary name just to pass validation.
--- End diff --
I wasn't clear; I don't have any issue with this part of the patch. I'm
suggesting _adding_ a check that we require the configSet. I needed to click
on some line to insert my comment; maybe I should have put my review comment on
the blank line.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
