[ https://issues.apache.org/jira/browse/SOLR-10734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16326871#comment-16326871 ]
Amrit Sarkar commented on SOLR-10734: ------------------------------------- Improvements listed in SOLR-11311. > Multithreaded test/support for AtomicURP broken > ----------------------------------------------- > > Key: SOLR-10734 > URL: https://issues.apache.org/jira/browse/SOLR-10734 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Reporter: Ishan Chattopadhyaya > Assignee: Noble Paul > Priority: Major > Fix For: master (8.0), 7.3 > > Attachments: SOLR-10734.patch, SOLR-10734.patch, SOLR-10734.patch, > Screen Shot 2017-05-31 at 4.50.23 PM.png, log-snippet, testMaster_2500, > testResults7_10, testResultsMaster_10 > > > The multithreaded test doesn't actually start the threads, but only invokes > the run directly. The join afterwards doesn't do anything, hence. > {code} > diff --git > a/solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateProcessorFactoryTest.java > > b/solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateProcessorFactoryTest.java > index f3f833d..10b7770 100644 > --- > a/solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateProcessorFactoryTest.java > +++ > b/solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateProcessorFactoryTest.java > @@ -238,7 +238,7 @@ public class AtomicUpdateProcessorFactoryTest extends > SolrTestCaseJ4 { > } > } > }; > - t.run(); > + t.run(); // red flag, shouldn't this be t.start? > threads.add(t); > finalCount += index; //int_i > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org