[
https://issues.apache.org/jira/browse/SOLR-11702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16335353#comment-16335353
]
Shalin Shekhar Mangar commented on SOLR-11702:
----------------------------------------------
Ok, thanks for clarifying Dat. A few more questions/comments:
# LIRRollingUpdatesTest.testNewReplicaOldLeader -- why is the proxy closed for
both leader and replica? Isn't closing for replica sufficient to force LIR?
# LIRRollingUpdatesTest calls TestInjection.reset() in tearDown but fault
injection isn't used anywhere in the test so it can be removed.
# Javadocs for ZkShardTerms.ensureTermIsHigher says "Ensure that leader's term
is lower than some replica's terms" but shouldn't the leader have a higher
term? This is also mentioned in the design document "The idea of _term_ is only
replicas (in the same shard) with highest term are considered healthy". The
impl is doing the opposite i.e. it is increasing the replica's term to
leaderTerm+1.
# Can you add javadocs to the various methods in the ZkShardTerms.Terms class?
> Redesign current LIR implementation
> -----------------------------------
>
> Key: SOLR-11702
> URL: https://issues.apache.org/jira/browse/SOLR-11702
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Cao Manh Dat
> Assignee: Cao Manh Dat
> Priority: Major
> Attachments: SOLR-11702.patch, SOLR-11702.patch
>
>
> I recently looked into some problem related to racing between LIR and
> Recovering. I would like to propose a totally new approach to solve SOLR-5495
> problem because fixing current implementation by a bandage will lead us to
> other problems (we can not prove the correctness of the implementation).
> Feel free to give comments/thoughts about this new scheme.
> https://docs.google.com/document/d/1dM2GKMULsS45ZMuvtztVnM2m3fdUeRYNCyJorIIisEo/edit?usp=sharing
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
