[ 
https://issues.apache.org/jira/browse/LUCENE-8136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337673#comment-16337673
 ] 

Karl Wright commented on LUCENE-8136:
-------------------------------------

1e-8 is unacceptably large.

It's also the case that if you had a check whether points were "identical", I 
suspect that your test cases would be found illegal because some of the test 
plane points would be identical or colinear (at that level of 
MINIMUM_RESOLUTION).  The plane constructor obviously doesn't look at this but 
the GeoPolygonFactory filters identical and coplanar points, so I suspect your 
plane test is not going to be realistic unless you make sure you do the same 
kind of filtering in it.


> Planes constructed with two points are wrong when points are close
> ------------------------------------------------------------------
>
>                 Key: LUCENE-8136
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8136
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/spatial3d
>            Reporter: Ignacio Vera
>            Assignee: Karl Wright
>            Priority: Major
>         Attachments: LUCENE-8136-RandomTest.patch
>
>
> Whenever a plane is constructed with two points (and the center of the 
> planet), and those points are close to each other,it might happen that the 
> final plane does not contain all points used for the construction. The issue 
> seems to happen when the resulting magnitude of the normal vector of the new 
> plane (calculated using cross product) is lower that 1e-5.
> This is a follow up of issue LUCENE-8133.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to