Ok, thanks Robert. This is a trivial correction. I didn't find log4j refs. anywhere under contrib/clustering (just to make sure), so I think it won't break anything.
Dawid On Fri, Jun 24, 2011 at 9:03 AM, Robert Muir <rcm...@gmail.com> wrote: > there is no code freeze anywhere... in my opinion, if you find little > things to fix, just commit!!! (and backport also to > http://svn.apache.org/repos/asf/lucene/dev/branches/lucene_solr_3_3/) > > I named the RC with the revision number, if we decide to go with it > anyway, we just use that rev for svn tagging. > But if lots of good things are found/fixed, then 'svn update' + 'ant > prepare-release' + sftp to create a second release candidate is no big > deal. > > On Fri, Jun 24, 2011 at 2:55 AM, Dawid Weiss > <dawid.we...@cs.put.poznan.pl> wrote: >> Is there a code freeze on 3x or can I apply SOLR-2620 to it? >> >> Dawid >> >> On Fri, Jun 24, 2011 at 8:51 AM, Dawid Weiss >> <dawid.we...@cs.put.poznan.pl> wrote: >>> I checked the clustering contrib, went through the Solr example (on >>> ubuntu). One thing I noticed: >>> >>> - we have duplicated log4j*.jar in the distribution; the one in >>> clustering contrib is not needed, in fact, because we use slf4j for >>> logging anyway (and this one is picked from the war's WEB-INF/lib. >>> I'll file an issue to remove it. >>> >>> Dawid >>> >>> On Fri, Jun 24, 2011 at 8:15 AM, Steven A Rowe <sar...@syr.edu> wrote: >>>> +1 >>>> >>>> I did the following: >>>> >>>> - compared the Solr & Lucene binary .zip and .tgz archives' contents for >>>> any differences (other than line endings) >>>> - skimmed Changes.html for generation problems >>>> - looked at random pages from each module's javadocs >>>> - ran the Lucene demo, indexed and searched >>>> - ran the Solr example server, indexed and searched >>>> - eyeballed all modules' Maven artifacts & sanity checked their POMs >>>> - ran all tests from the Solr & Lucene source tarballs, separately >>>> >>>> Two non-release-blocking nits: >>>> >>>> 1. In the Solr source tarball, solr/example/README.txt recommends using >>>> the command "./post.sh *.xml" from solr/example/exampledocs/, but post.sh >>>> does not have executable permissions. In the binary tarball, however, >>>> post.sh has executable permissions. >>>> >>>> 2. I checked the source for references to older versions, and I found the >>>> following; I think these just point to a missing item in the release todo >>>> (post-branching), and should not block the release: >>>> >>>> ./lucene/contrib/analyzers/common/src/java/org/apache/lucene/analysis/fr/FrenchStemFilter.java: >>>> @Deprecated // TODO remove in 3.2 (this is present twice in this file) >>>> >>>> ./lucene/src/java/org/apache/lucene/index/ConcurrentMergeScheduler.java: >>>> /** @deprecated remove all this test mode code in lucene 3.2! */ >>>> >>>> ./lucene/contrib/analyzers/common/src/java/org/apache/lucene/analysis/br/BrazilianAnalyzer.java: >>>> // TODO make this private in 3.1 (this is present twice in this file) >>>> >>>> ./lucene/contrib/demo/src/java/org/apache/lucene/demo/IndexFiles.java:/** >>>> Index all text files under a directory. See >>>> http://lucene.apache.org/java/3_1/demo.html. */ >>>> >>>> ./lucene/contrib/demo/src/java/org/apache/lucene/demo/IndexFiles.java: + >>>> "See http://lucene.apache.org/java/3_1/demo.html for details."; >>>> >>>> Steve >>>> >>>>> -----Original Message----- >>>>> From: Robert Muir [mailto:rcm...@gmail.com] >>>>> Sent: Thursday, June 23, 2011 4:18 PM >>>>> To: dev@lucene.apache.org >>>>> Subject: [VOTE] release 3.3 >>>>> >>>>> Artifacts here: >>>>> >>>>> http://s.apache.org/lusolr33rc0 >>>>> >>>>> working release notes here: >>>>> >>>>> http://wiki.apache.org/lucene-java/ReleaseNote33 >>>>> http://wiki.apache.org/solr/ReleaseNote33 >>>>> >>>>> I ran the automated release test script in >>>>> trunk/dev-tools/scripts/smokeTestRelease.py, and ran 'ant test' at the >>>>> top level 50 times on windows. >>>>> Here is my +1 >>>> >>>> >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org >> For additional commands, e-mail: dev-h...@lucene.apache.org >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > For additional commands, e-mail: dev-h...@lucene.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
