[ https://issues.apache.org/jira/browse/SOLR-11892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16338601#comment-16338601 ]
Robert Muir commented on SOLR-11892: ------------------------------------ Exceptions are cheap, deleting files is scary and I am against such "optimizations". I see these issues being opened across the solr project but someone is either horribly confused by their profiler's sampling bias, smoking crack, or both. > Avoid unnecessary exceptions in FSDirectory and RAMDirectory > ------------------------------------------------------------ > > Key: SOLR-11892 > URL: https://issues.apache.org/jira/browse/SOLR-11892 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Reporter: Erick Erickson > Assignee: Erick Erickson > Priority: Minor > > In privateDeleteFile, just use deleteIfExists. > in RamDirectory we can declare a static exception and create it once. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org