[
https://issues.apache.org/jira/browse/SOLR-11597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356085#comment-16356085
]
Christine Poerschke commented on SOLR-11597:
--------------------------------------------
Hi, [~malcorn_redhat].
bq. ... I've also added a Layer class that I believe makes the logic of the
calculations clearer. ...
It does indeed, nice.
Just sent you a small [pull
request|https://github.com/airalcorn2/lucene-solr/pull/2]. Had noticed that the
model's validate was not yet calling the layers' validate and so added that,
and that the model's explain could delegate the describe-yourself to each
layer, and then it was just one small extra step to the
{code}
- public class Layer {
+ public interface Layer {
+ public float[] calculateOutput(float[] inputVec);
+ public int validate(int inputDim) throws ModelException;
+ public String describe();
+ }
+
+ public class DefaultLayer implements Layer {
{code}
abstraction - what do you think? Combined with a protected instead of private
createLayer method and that would even give a way for custom classes to add
custom layers.
Next step for me (not today), (re)run the (extended) tests, had issues with
them earlier.
> Implement RankNet.
> ------------------
>
> Key: SOLR-11597
> URL: https://issues.apache.org/jira/browse/SOLR-11597
> Project: Solr
> Issue Type: New Feature
> Security Level: Public(Default Security Level. Issues are Public)
> Components: contrib - LTR
> Reporter: Michael A. Alcorn
> Assignee: Christine Poerschke
> Priority: Major
> Fix For: 7.3
>
>
> Implement RankNet as described in [this
> tutorial|https://github.com/airalcorn2/Solr-LTR].
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
