[
https://issues.apache.org/jira/browse/SOLR-11925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16357477#comment-16357477
]
David Smiley commented on SOLR-11925:
-------------------------------------
bq. Why is remoteInvoke on RouedAliasCreateCollectionCommand when it's only
used from TimeRoutedAliasUpdateProcessor?
I thought it might be nice to have a static method on the command with typed
arguments so that it's (a) easy to invoke remotely, and (b) keeps details of
composing & writing the message in one class. Do you think this is worse?
bq. Rename field on zkstateReader aliasesHolder to aliasesManager?
+1 will do
bq. You added 2 parseSolrDateToInstant() methods with different params, but
neither seems to be used?
Whoops. I'll delete them; they are one-liners any way.
bq. you seem to have dropped some conditionals looking for null or -1 error
codes
That moved to a new method on SolrResponse: getException(). I appreciate it's
complicated to follow this in the diff; I found the original code being
refactored difficult to understand.
bq. Thinking about the validation in TimeRoutedAlias...
Good commentary... yeah something to be mindful of in ModifyAlias in the future.
bq. We seem to rely on applyModificationandExportToZk to ensure that the alias
is updated before deleting collections, but I think that's a little risky...
The code here is running on the node that has the Overseer, and thus issuing an
admin command to delete the collection from the same node "sees" the same state
(I think). If I'm wrong, what you describe doesn't sound serious?
deleteOldestCollectionsAndUpdateAlias() will not throw an exception (thus won't
prevent creating next collection), it will return errors in the overseer
message response if there are any (results.add(...)). If this comes to pass,
we could modify DeleteCollectionCmd to ensure it's aliases is up to date first.
bq. Javadoc/doc
+1 will do.
> Auto delete oldest collections in a time routed alias
> -----------------------------------------------------
>
> Key: SOLR-11925
> URL: https://issues.apache.org/jira/browse/SOLR-11925
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Major
> Fix For: 7.3
>
> Attachments: SOLR-11925.patch
>
>
> The oldest collections in a Time Routed Alias should be automatically
> deleted, according to a new alias metadata that establishes how long. It can
> be checked as new data flows in at TimeRoutedAliasUpdateProcessor and thus it
> won't occur if new data isn't coming in.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
