[ 
https://issues.apache.org/jira/browse/SOLR-8389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16359068#comment-16359068
 ] 

Peter Rusko commented on SOLR-8389:
-----------------------------------

Hi Amrit,

You've completely removed all the collection properties code, which could be 
useful not just for this patch, but some other use cases too. I've created 
SOLR-11960 to track that feature. I still think storing the properties that way 
has a lot of value and you could use it for CDCR properties too. It is more 
generic, and should be easily extendable, should you need to add validation of 
the property, or a way to set them at collection creation time.

> Convert CDCR peer cluster and other configurations into collection properties 
> modifiable via APIs
> -------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-8389
>                 URL: https://issues.apache.org/jira/browse/SOLR-8389
>             Project: Solr
>          Issue Type: Improvement
>          Components: CDCR, SolrCloud
>            Reporter: Shalin Shekhar Mangar
>            Priority: Major
>         Attachments: SOLR-8389.patch, SOLR-8389.patch, SOLR-8389.patch, 
> SOLR-8389.patch, SOLR-8389.patch, SOLR-8389.patch, SOLR-8389.patch, 
> SOLR-8389.patch, SOLR-8389.patch, SOLR-8389.patch, SOLR-8389.patch, Screen 
> Shot 2017-12-21 at 5.44.36 PM.png
>
>
> CDCR configuration is kept inside solrconfig.xml which makes it difficult to 
> add or change peer cluster configuration.
> I propose to move all CDCR config to collection level properties in cluster 
> state so that they can be modified using the existing modify collection API.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to