Hi Martin,
this class was a test-only class, so I don’t think it’s of use for production end users. Why should we add it to SolrCLI? Uwe ----- Uwe Schindler Achterdiek 19, D-28357 Bremen http://www.thetaphi.de <http://www.thetaphi.de/> eMail: u...@thetaphi.de From: Martin Gainty [mailto:mgai...@hotmail.com] Sent: Monday, February 12, 2018 4:27 AM To: dev@lucene.apache.org Subject: Re: SecureRandomAlgorithmTesterApp ?? _____ From: Uwe Schindler <u...@thetaphi.de <mailto:u...@thetaphi.de> > Sent: Sunday, February 11, 2018 6:41 PM To: dev@lucene.apache.org <mailto:dev@lucene.apache.org> Subject: SecureRandomAlgorithmTesterApp ?? Hi, in Solr's Core test class is a file "SecureRandomAlgorithmTesterApp.java" in the default package. It is also compiled, but not used anywhere. It does not appear in Javadocs (as it's test only), but the updated weekly OpenClover coverage report list it as a completely untested class file in the default package. I'd like to delete it unless there is a use-case for it. Maybe let's move it into a package, if it's of use. It seems to be a command line program to test some SecureRandomConfigs in the JVM. It was added by: SOLR-10338: Configure SecureRandom non blocking for tests (Mark Miller). I think it was just some testing when SecureRandom support was added and got accidentally committed to source tree. MG>would it make sense to copy SecureRandomAlgorithmTesterApp as static inner class inside org.apache.solr.util.SOLRCLI ? http://grepcode.com/file/repo1.maven.org/maven2/org.apache.solr/solr-core/5.2.0/org/apache/solr/util/SolrCLI.java#SolrCLI.ApiTool <http://grepcode.com/file/repo1.maven.org/maven2/org.apache.solr/solr-core/5.2.0/org/apache/solr/util/SolrCLI.java#SolrCLI.ApiTool> GC: SolrCLI - org.apache.solr.util.SolrCLI (.java) - GrepCode Class Source grepcode.com org.apache.solr.util.SolrCLI - Command-line utility for working with Solr MG>WDYT? Uwe ----- Uwe Schindler Achterdiek 19, D-28357 Bremen http://www.thetaphi.de eMail: u...@thetaphi.de <mailto:u...@thetaphi.de> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org <mailto:dev-unsubscr...@lucene.apache.org> For additional commands, e-mail: dev-h...@lucene.apache.org <mailto:dev-h...@lucene.apache.org>
