[ 
https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366903#comment-16366903
 ] 

Koji Sekiguchi commented on SOLR-11795:
---------------------------------------

Today I had a meeting with Minoru, the contributor of this patch. We discussed 
in detail about this contribution and I found this is very nice!

There is a similar ticket SOLR-10654, which implements ResponseWriter for 
Prometheus and is called thru wt parameter, but I prefer Minoru's way.  Why I 
prefer this is because:

* This is highly independent from Solr main unit. He just makes 
contrib/prometheus-exporter directory and provides everything under it, 
including SolrExporter for Prometheus in this patch. This patch doesn't change 
Solr main source.
* Implementing an exporter looks mainstream in Prometheus field, such as MySQL, 
Memcached, Mesos, etc. See https://prometheus.io/docs/instrumenting/exporters/
* Solrj is used to implement SolrExporter in this patch. It can be used on 
SolrCloud environment.
* It allows users to monitor not only Solr metrics which come from 
/admin/metrics but also facet counts which come from /select (see config.yml in 
the patch).

I requested him to update the patch in terms of providing Ref Guide (he already 
wrote README.md so just move its contents to Ref Guide) and adding more tests 
so that we can know the change of the response format of /admin/metrics if it 
happens.

I'll wait for his next patch. Once I got it and nobody objects, I'd like to 
commit this in the next week.

> Add Solr metrics exporter for Prometheus
> ----------------------------------------
>
>                 Key: SOLR-11795
>                 URL: https://issues.apache.org/jira/browse/SOLR-11795
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: metrics
>    Affects Versions: 7.2
>            Reporter: Minoru Osuka
>            Assignee: Koji Sekiguchi
>            Priority: Minor
>         Attachments: SOLR-11795-2.patch, SOLR-11795-3.patch, 
> SOLR-11795-4.patch, SOLR-11795-5.patch, SOLR-11795.patch, solr-dashboard.png, 
> solr-exporter-diagram.png
>
>
> I 'd like to monitor Solr using Prometheus and Grafana.
> I've already created Solr metrics exporter for Prometheus. I'd like to 
> contribute to contrib directory if you don't mind.
> !solr-exporter-diagram.png|thumbnail!
> !solr-dashboard.png|thumbnail!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to