[ 
https://issues.apache.org/jira/browse/SOLR-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16373889#comment-16373889
 ] 

Michael Gibney commented on SOLR-7798:
--------------------------------------

I was able to reproduce an NPE with the above command; but the test only threw 
this NPE intermittently, and I was able to reproduce it on master 
(364b680afaf9) as well. I've included the stack trace to make sure we're 
talking about the same issue.
{code:java}
[junit4] 2> 2778 ERROR (searcherExecutor-7-thread-1) [ ] o.a.s.s.LRUCache Error 
during auto-warming of 
key:org.apache.solr.search.QueryResultKey@7ce6ad2e:java.lang.RuntimeException: 
java.lang.NullPointerException
[junit4] 2> at 
org.apache.solr.search.CollapsingQParserPlugin$CollapsingPostFilter.getFilterCollector(CollapsingQParserPlugin.java:378)
[junit4] 2> at 
org.apache.solr.search.SolrIndexSearcher.getProcessedFilter(SolrIndexSearcher.java:1084)
[junit4] 2> at 
org.apache.solr.search.SolrIndexSearcher.getDocListNC(SolrIndexSearcher.java:1540)
[junit4] 2> at 
org.apache.solr.search.SolrIndexSearcher.getDocListC(SolrIndexSearcher.java:1416)
[junit4] 2> at 
org.apache.solr.search.SolrIndexSearcher.access$000(SolrIndexSearcher.java:90)
[junit4] 2> at 
org.apache.solr.search.SolrIndexSearcher$3.regenerateItem(SolrIndexSearcher.java:575)
[junit4] 2> at org.apache.solr.search.LRUCache.warm(LRUCache.java:297)
[junit4] 2> at 
org.apache.solr.search.SolrIndexSearcher.warm(SolrIndexSearcher.java:2146)
[junit4] 2> at 
org.apache.solr.core.SolrCore.lambda$getSearcher$16(SolrCore.java:2258)
[junit4] 2> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[junit4] 2> at 
org.apache.solr.common.util.ExecutorUtil$MDCAwareThreadPoolExecutor.lambda$execute$0(ExecutorUtil.java:188)
[junit4] 2> at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
[junit4] 2> at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
[junit4] 2> at java.lang.Thread.run(Thread.java:745)
[junit4] 2> Caused by: java.lang.NullPointerException
[junit4] 2> at 
org.apache.solr.search.CollapsingQParserPlugin$OrdScoreCollector.<init>(CollapsingQParserPlugin.java:514)
[junit4] 2> at 
org.apache.solr.search.CollapsingQParserPlugin$CollectorFactory.getCollector(CollapsingQParserPlugin.java:1331)
[junit4] 2> at 
org.apache.solr.search.CollapsingQParserPlugin$CollapsingPostFilter.getFilterCollector(CollapsingQParserPlugin.java:367)
[junit4] 2> ... 13 more
{code}

> Improve robustness of ExpandComponent
> -------------------------------------
>
>                 Key: SOLR-7798
>                 URL: https://issues.apache.org/jira/browse/SOLR-7798
>             Project: Solr
>          Issue Type: Improvement
>          Components: SearchComponents - other
>            Reporter: Jörg Rathlev
>            Assignee: Joel Bernstein
>            Priority: Minor
>         Attachments: expand-component.patch, expand-npe.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The {{ExpandComponent}} causes a {{NullPointerException}} if accidentally 
> used without prior collapsing of results.
> If there are multiple documents in the result which have the same term value 
> in the expand field, the size of the {{ordBytes}}/{{groupSet}} differs from 
> the {{count}} value, and the {{getGroupQuery}} method creates an incompletely 
> filled {{bytesRef}} array, which later causes a {{NullPointerException}} when 
> trying to sort the terms.
> The attached patch extends the test to demonstrate the error, and modifies 
> the {{getGroupQuery}} methods to create the array based on the size of the 
> input maps.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to