[ https://issues.apache.org/jira/browse/LUCENE-8106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375511#comment-16375511 ]
Uwe Schindler edited comment on LUCENE-8106 at 2/24/18 11:34 AM: ----------------------------------------------------------------- Hi patch looks fine, but it's not fully correct: - Policeman and ASF jenkins use "-Dargs=...". Those arguments are passed to the underlying test JVM runners. - Sarowe's Jenkins uses {{ANT_OPTS}} environment variable. But this is something completely different. It is just options that are passed to ANT's JVM (the JVM that runs the build scripts). Those won't be passed to test runners. Contrary, in the python script they are passed like other ant arguments, which is wrong. The ANT_OPTS stuff should be removed from the script, it has nothing to do with reproducing tests. It's just some tuning of Ant's JVM (which should no longer necessary for Sarowe Jenkins, unless it runs with Java 7). If Jenkins would use {{ANT_ARGS}} env var instead, then you could pass it. See documentation here: https://ant.apache.org/manual/running.html was (Author: thetaphi): Hi patch looks fine, but it's not fully correct: - Policeman and ASF jenkins use "-Dargs=...". Those arguments are passed to the usndelying test JVM runners. - Sarowe's Jenkins uses {{ANT_OPTS}} environment variable. But this is something completely different. It is just options that are passed to ANT's JVM (the JVM that runs the build scripts). Those won't be passed to test runners. Contrary, in the python script they are passed like other ant arguments, which is wrong. The ANT_OPTS stuff should be removed from the script, it has nothing to do with reproducing tests. It's just some tuning of Ant's JVM (which should no longer necessary for Sarowe Jenkins, unless it runs with Java 7). If Jenkins would use {{ANT_ARGS}} env var instead, then you could pass it. See documentation here: https://ant.apache.org/manual/running.html > Add script to attempt to reproduce failing tests from a Jenkins log > ------------------------------------------------------------------- > > Key: LUCENE-8106 > URL: https://issues.apache.org/jira/browse/LUCENE-8106 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Steve Rowe > Assignee: Steve Rowe > Priority: Major > Fix For: master (8.0), 7.3 > > Attachments: LUCENE-8106-part2.patch, LUCENE-8106-part3.patch, > LUCENE-8106-part4.patch, LUCENE-8106.patch, LUCENE-8106.patch > > > This script will be runnable from a downstream job triggered by an upstream > failing Jenkins job, passing log location info between the two. > The script will also be runnable manually from a developer's cmdline. > From the script help: > {noformat} > Usage: > python3 -u reproduceJenkinsFailures.py URL > Must be run from a Lucene/Solr git workspace. Downloads the Jenkins > log pointed to by the given URL, parses it for Git revision and failed > Lucene/Solr tests, checks out the Git revision in the local workspace, > groups the failed tests by module, then runs > 'ant test -Dtest.dups=5 -Dtests.class="*.test1[|*.test2[...]]" ...' > in each module of interest, failing at the end if any of the runs fails. > To control the maximum number of concurrent JVMs used for each module's > test run, set 'tests.jvms', e.g. in ~/lucene.build.properties > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org