[
https://issues.apache.org/jira/browse/LUCENE-8190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385324#comment-16385324
]
Ignacio Vera commented on LUCENE-8190:
--------------------------------------
Noted the issue with javadocs.
I think there is some inconsistency how this property is treated. It seems it
belongs to the cell but RPT strategy treats it as a property of the tree.
I was thinking in a (probably non realistic) tree with mixed type of cells.
They will not be treated as expected as it stops iterating at the first cell
that does not implement the new interface.
I am not sure if it is too aggressive but the logic should visit all cells
regardless the type and stop when trying to prune if cell is not eligible not
before. I attach a patch with the idea.
> Replace dendency on LegacyCell for setting pruneLeafyBranches on
> RecursivePrefixTreeStrategy
> --------------------------------------------------------------------------------------------
>
> Key: LUCENE-8190
> URL: https://issues.apache.org/jira/browse/LUCENE-8190
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/spatial-extras
> Reporter: Ignacio Vera
> Priority: Major
> Attachments: LUCENE-8190.patch, LUCENE-8190.patch
>
>
> The setting {{pruneLeafyBranches}} on {{RecursivePrefixTreeStrategy}} depends
> on abstract class {{LegacyCell}} and therefore trees like the newly added
> {{S2PrefixTree}} cannot benefit for such optimization.
> It is proposed to add a new specialize interface for {{cell}} interface and
> make the setting depends on it instead of {{LegacyCell.}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
