[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16387754#comment-16387754 ]
Cassandra Targett commented on SOLR-11795: ------------------------------------------ Can we remove the {{monitoring-solr-with-prometheus-and-grafana.adoc}} changes from the patch? When I said I was "reviewing" it as committed, I should have said I was actually doing some extensive structural changes to the page. I can use the added info in the patch to augment the information within the changes I'm making, but if you commit those changes I'll have a big conflict to work through. FYI, among the changes I'm making to {{monitoring-solr-with-prometheus-and-grafana.adoc}}: * Changing the solr-exporter help output section to a labeled list of properly presented parameters * Changing parameters in tables to labeled lists * Adding more context to the instructions throughout based on a first-time experience setting it up and using it * Correcting paths to the contrib folder and files within it * Adding a tab section for the startup instructions to present Linux & Windows * Adding context to the solr-exporter configuration file to explain its overall structure I'm only about halfway through, but the page will be a much more complete section of documentation when I'm done. I could have made these recommendations earlier, but I was busy with other things and didn't get a chance. > Add Solr metrics exporter for Prometheus > ---------------------------------------- > > Key: SOLR-11795 > URL: https://issues.apache.org/jira/browse/SOLR-11795 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: metrics > Affects Versions: 7.2 > Reporter: Minoru Osuka > Assignee: Koji Sekiguchi > Priority: Minor > Fix For: master (8.0), 7.3 > > Attachments: SOLR-11795-10.patch, SOLR-11795-11.patch, > SOLR-11795-2.patch, SOLR-11795-3.patch, SOLR-11795-4.patch, > SOLR-11795-5.patch, SOLR-11795-6.patch, SOLR-11795-7.patch, > SOLR-11795-8.patch, SOLR-11795-9.patch, SOLR-11795-dev-tools.patch, > SOLR-11795-ref-guide.patch, SOLR-11795.patch, solr-dashboard.png, > solr-exporter-diagram.png > > Time Spent: 20m > Remaining Estimate: 0h > > I 'd like to monitor Solr using Prometheus and Grafana. > I've already created Solr metrics exporter for Prometheus. I'd like to > contribute to contrib directory if you don't mind. > !solr-exporter-diagram.png|thumbnail! > !solr-dashboard.png|thumbnail! -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org