[ 
https://issues.apache.org/jira/browse/SOLR-7887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16389098#comment-16389098
 ] 

Erick Erickson commented on SOLR-7887:
--------------------------------------

I backed out making the configs the same, and fixed the problem with 
compilation. What happened is that the check in for the prometheus-exporter had 
to have its dependencies updated just like a number of the other contribs.

TestLogWatcher still fails, but only when run as part of the full test suite 
(or at least more commonly).

If we can get TestLogWatcher fixed and do some real-world tests I'll consider 
this patch ready to commit. I think we should wait until after 7.3 had been 
branched though to give it time to bake.

The test error isn't very informative:
   [junit4] Suite: org.apache.solr.logging.TestLogWatcher
   [junit4]   2> 2452861 WARN  (main) [    ] o.a.s.l.TestLogWatcher This is a 
test message
   [junit4] FAILURE 0.01s J3 | TestLogWatcher.testLog4jWatcher <<<
   [junit4]    > Throwable #1: java.lang.AssertionError
   [junit4]    >        at 
org.apache.solr.logging.TestLogWatcher.testLog4jWatcher(TestLogWatcher.java:49)
   [junit4] Completed [664/782 (5!)] on J3 in 0.04s, 1 test, 1 failure <<< 
FAILURES!

> Upgrade Solr to use log4j2 -- log4j 1 now officially end of life
> ----------------------------------------------------------------
>
>                 Key: SOLR-7887
>                 URL: https://issues.apache.org/jira/browse/SOLR-7887
>             Project: Solr
>          Issue Type: Task
>    Affects Versions: 5.2.1
>            Reporter: Shawn Heisey
>            Assignee: Varun Thacker
>            Priority: Major
>         Attachments: SOLR-7887-WIP.patch, SOLR-7887-eoe-review.patch, 
> SOLR-7887-eoe-review.patch, SOLR-7887.patch, SOLR-7887.patch, 
> SOLR-7887.patch, SOLR-7887.patch, SOLR-7887.patch, SOLR-7887.patch, 
> SOLR-7887.patch, SOLR-7887.patch, SOLR-7887.patch, SOLR-7887.patch, 
> SOLR-7887.patch
>
>
> The logging services project has officially announced the EOL of log4j 1:
> https://blogs.apache.org/foundation/entry/apache_logging_services_project_announces
> In the official binary jetty deployment, we use use log4j 1.2 as our final 
> logging destination, so the admin UI has a log watcher that actually uses 
> log4j and java.util.logging classes.  That will need to be extended to add 
> log4j2.  I think that might be the largest pain point to this upgrade.
> There is some crossover between log4j2 and slf4j.  Figuring out exactly which 
> jars need to be in the lib/ext directory will take some research.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to