[GitHub] lucene-solr pull request #335: SOLR-11617 rename alias metadata as alias pro...

[dsmiley]

Github user dsmiley commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/335#discussion_r173641664
  
    --- Diff: 
solr/core/src/test/org/apache/solr/cloud/AliasIntegrationTest.java ---
    @@ -238,51 +239,52 @@ public void testModifyMetadataV2() throws Exception {
         checkFooAndBarMeta(aliasName, zkStateReader);
       }
     
    -  public void testModifyMetadataV1() throws Exception {
    +  @Test
    +  public void testModifyPropertiesV1() throws Exception {
         // note we don't use TZ in this test, thus it's UTC
         final String aliasName = getTestName();
         ZkStateReader zkStateReader = createColectionsAndAlias(aliasName);
         final String baseUrl = 
cluster.getRandomJetty(random()).getBaseUrl().toString();
    -    HttpGet get = new HttpGet(baseUrl + 
"/admin/collections?action=MODIFYALIAS" +
    +    HttpGet get = new HttpGet(baseUrl + 
"/admin/collections?action=ALIASPROP" +
             "&wt=xml" +
             "&name=" + aliasName +
    -        "&metadata.foo=baz" +
    -        "&metadata.bar=bam");
    +        "&properties.foo=baz" +
    --- End diff --
    
    What you have for V2 (a JSON API) — “properties” is good. I’m 
directing my feedback expressly at V1 for “property”, which is a param 
prefix, not JSON. Again, see the existing APIs like core properties which 
already set this precedent. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org