[ 
https://issues.apache.org/jira/browse/LUCENE-3475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16396416#comment-16396416
 ] 

David Smiley commented on LUCENE-3475:
--------------------------------------

bq. Some of this behaviour is different to the standard ShingleFilter, so I 
think we should probably keep them separate (while deprecating the old version 
and removing in master)

Wouldn't this be a Version switch situation instead?  Why bother the users with 
a new name instead?

> ShingleFilter should handle positionIncrement of zero, e.g. synonyms
> --------------------------------------------------------------------
>
>                 Key: LUCENE-3475
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3475
>             Project: Lucene - Core
>          Issue Type: New Feature
>          Components: modules/analysis
>            Reporter: Cameron
>            Assignee: Alan Woodward
>            Priority: Minor
>              Labels: newdev
>         Attachments: LUCENE-3475.patch, LUCENE-3475.patch
>
>
> ShingleFilter is creating shingles for a single term that has been expanded 
> by synonyms when it shouldn't. The position increment is 0.
> As an example, I have an Analyzer with a SynonymFilter followed by a 
> ShingleFilter. Assuming car and auto are synonyms, the SynonymFilter produces 
> two tokens and position 1: car, auto. The ShingleFilter is then producing 3 
> tokens, when there should only be two: car, car auto, auto. This behavior 
> seems incorrect.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to