[ 
https://issues.apache.org/jira/browse/LUCENE-8214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404596#comment-16404596
 ] 

Ignacio Vera commented on LUCENE-8214:
--------------------------------------

It uses equals to compare a Boolean object with a boolean primitive. This 
situation is treated as a comparison of primitive {{boolean}} values so it is 
robust.

> Improve selection of testPoint for GeoComplexPolygon
> ----------------------------------------------------
>
>                 Key: LUCENE-8214
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8214
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/spatial3d
>            Reporter: Ignacio Vera
>            Assignee: Karl Wright
>            Priority: Major
>             Fix For: 6.7, 7.4, master (8.0)
>
>         Attachments: LUCENE-8214.patch
>
>
> I have been checking the effect of the testPoint on GeoComplexPolygon and it 
> seems performance can change quite a bit depending on the choice. 
> The results with random polygons with 20k points shows that a good choice is 
> to ue the center of mass of the shape. On the worst case the performance is 
> similar to what we have now and the best case is twice as fast for 
> {{within()}} and {{getRelationship()}} methods.
> Therefore I would like to propose to use that point whenever possible.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to