[
https://issues.apache.org/jira/browse/LUCENE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16412469#comment-16412469
]
Karl Wright commented on LUCENE-8220:
-------------------------------------
Indeed, suppressing the creation of that triangle leads to a further failure:
{code}
[junit4] ERROR 0.01s J1 | GeoPolygonTest.testCoplanarityTileConvex <<<
[junit4] > Throwable #1: java.lang.IllegalArgumentException: Cannot
determine sidedness because check point is on plane.
[junit4] > at
org.apache.lucene.spatial3d.geom.SidedPlane.<init>(SidedPlane.java:113)
[junit4] > at
org.apache.lucene.spatial3d.geom.GeoPolygonFactory$EdgeBuffer.<init>(GeoPolygonFactory.java:1494)
[junit4] > at
org.apache.lucene.spatial3d.geom.GeoPolygonFactory.buildPolygonShape(GeoPolygonFactory.java:757)
[junit4] > at
org.apache.lucene.spatial3d.geom.GeoPolygonFactory.buildPolygonShape(GeoPolygonFactory.java:934)
[junit4] > at
org.apache.lucene.spatial3d.geom.GeoPolygonFactory.buildPolygonShape(GeoPolygonFactory.java:934)
[junit4] > at
org.apache.lucene.spatial3d.geom.GeoPolygonFactory.generateGeoPolygon(GeoPolygonFactory.java:379)
[junit4] > at
org.apache.lucene.spatial3d.geom.GeoPolygonFactory.makeGeoPolygon(GeoPolygonFactory.java:171)
[junit4] > at
org.apache.lucene.spatial3d.geom.GeoPolygonFactory.makeGeoPolygon(GeoPolygonFactory.java:96)
[junit4] > at
org.apache.lucene.spatial3d.geom.GeoPolygonFactory.makeGeoPolygon(GeoPolygonFactory.java:50)
[junit4] > at
org.apache.lucene.spatial3d.geom.GeoPolygonTest.testCoplanarityTileConvex(GeoPolygonTest.java:1123)
{code}
So, basically, the logic upstream needs to change to perform the shape
breakdown differently. I'll have to think through how.
> GeoPolygon factory still shows problems with coplanar points
> ------------------------------------------------------------
>
> Key: LUCENE-8220
> URL: https://issues.apache.org/jira/browse/LUCENE-8220
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/spatial3d
> Reporter: Ignacio Vera
> Assignee: Karl Wright
> Priority: Major
> Attachments: concave.jpg, concaveWithTiling.jpg,
> coplanarity-test.patch
>
>
> The attached patch contains two polygons that still shows problems with
> co-planar points. To better explain the issue I attached some images:
> 1) concave.jpg: This is the polygon we want to build. Note that we want to
> build the concave part, therefore the blue part is actually not part of the
> shape and the white part is the area cover by the shape.
> 2) concaveWithTiling.jpg: The algorithm of the polygon factory tries to tile
> the polygon using convex polygons. In our case it creates the three colored
> polygons on the image. What it remains is a concave polygon.
> The problem with this polygon is that the right edge of the concave polygon
> contains co-planar points. These points cannot be merged into a single plane
> because they have different properties (internal edges or shape edges).
> Because GeoConvexPolygon and GeoConcavePolygon cannot handle polygons with
> co-planar points, the polygon cannot be built.
> [~kwri...@metacarta.com], Is it possible to make this polygons support such
> an extreme case?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
