[ 
https://issues.apache.org/jira/browse/LUCENE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16412735#comment-16412735
 ] 

Karl Wright commented on LUCENE-8220:
-------------------------------------

[~ivera], when I apply the patch and un-ignore the test, that test passes, but 
other tests fail, e.g.:

{code}
   [junit4] Suite: org.apache.lucene.spatial3d.geom.RandomGeoPolygonTest
   [junit4]   2> NOTE: reproduce with: ant test  
-Dtestcase=RandomGeoPolygonTest -Dtests.method=testCoplanarityTilePolygon 
-Dtests.seed=A69C6E2335E509EF -Dtests.slow=true -Dtests.badapples=true 
-Dtests.locale=is-IS -Dtests.tim
ezone=Pacific/Galapagos -Dtests.asserts=true -Dtests.file.encoding=Cp1252
   [junit4] FAILURE 0.15s J1 | RandomGeoPolygonTest.testCoplanarityTilePolygon 
<<<
   [junit4]    > Throwable #1: java.lang.AssertionError
   [junit4]    >        at 
__randomizedtesting.SeedInfo.seed([A69C6E2335E509EF:DF4889912003CEF6]:0)
   [junit4]    >        at 
org.apache.lucene.spatial3d.geom.RandomGeoPolygonTest.testCoplanarityTilePolygon(RandomGeoPolygonTest.java:85)
   [junit4]    >        at java.lang.Thread.run(Thread.java:745)
   [junit4]   2> NOTE: test params are: codec=Asserting(Lucene70): {}, 
docValues:{}, maxPointsInLeafNode=1050, maxMBSortInHeap=7.671874176950007, 
sim=Asserting(org.apache.lucene.search.similarities.AssertingSimilarity@580819b1
), locale=is-IS, timezone=Pacific/Galapagos
   [junit4]   2> NOTE: Windows 8.1 6.3 amd64/Oracle Corporation 1.8.0_45 
(64-bit)/cpus=4,threads=1,free=119276696,total=128974848
   [junit4]   2> NOTE: All tests run in this JVM: [RandomGeoPolygonTest]
{code}


> GeoPolygon factory still shows problems with coplanar points
> ------------------------------------------------------------
>
>                 Key: LUCENE-8220
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8220
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/spatial3d
>            Reporter: Ignacio Vera
>            Assignee: Karl Wright
>            Priority: Major
>         Attachments: concave.jpg, concaveWithTiling.jpg, 
> coplanarity-test.patch, factory.patch
>
>
> The attached patch contains two polygons that still shows problems with 
> co-planar points. To better explain the issue I attached some images:
> 1) concave.jpg:  This is the polygon we want to build. Note that we want to 
> build the concave part, therefore the blue part is actually not part of the 
> shape and the white part is the area cover by the shape.
> 2) concaveWithTiling.jpg: The algorithm of the polygon factory tries to tile 
> the polygon using convex polygons. In our case it creates the three colored 
> polygons on the image. What it remains is a concave polygon.
> The problem with this polygon is that the right edge of the concave polygon 
> contains co-planar points. These points cannot be merged into a single plane 
> because they have different properties (internal edges or shape edges).
> Because GeoConvexPolygon and GeoConcavePolygon cannot handle polygons with 
> co-planar points, the polygon cannot be built.
> [[email protected]], Is it possible to make this polygons support such 
> an extreme case?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to