[
https://issues.apache.org/jira/browse/SOLR-7887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413399#comment-16413399
]
Varun Thacker commented on SOLR-7887:
-------------------------------------
5. In solr/contrib/prometheus-exporter/ivy.xml , why is the "log4j-slf4j-impl"
dependency "test" and not "compile" ?
Excerpt where this was changed
{code:java}
- <dependency org="org.slf4j" name="slf4j-log4j12"
rev="${/org.slf4j/slf4j-log4j12}" conf="compile"/>
+ <dependency org="org.apache.logging.log4j" name="log4j-slf4j-impl"
rev="${/org.apache.logging.log4j/log4j-slf4j-impl}" conf="test"/>{code}
6. The commit to JettySolrRunner.java seems like a cruft from a older patch?
7. In solr/server/resources/log4j2.xml , we have added this
{code:java}
fileName="${sys:solr.solr.home}/../logs/solr.log"{code}
why is it "solr.solr.home" ? Shouldn't it be ${solr.log} ?
>From the older log4j.properties
{code:java}
log4j.appender.file.File=${solr.log}/solr.log{code}
8. In solr/server/scripts/cloud-scripts/log4j2.xml , we have this line
{code:java}
<Logger name="log4j.logger.org.apache.solr.common.cloud" level="WARN"/>{code}
the "log4j.logger" should be excluded right?
9. Similarly in solr/solrj/src/test-files/log4j2.xml and
solr/solrj/src/test-files/log4j.properties we need to fix this?
{code:java}
<Logger name="log4j.logger.org.apache.solr.hadoop" level="INFO"/>{code}
> Upgrade Solr to use log4j2 -- log4j 1 now officially end of life
> ----------------------------------------------------------------
>
> Key: SOLR-7887
> URL: https://issues.apache.org/jira/browse/SOLR-7887
> Project: Solr
> Issue Type: Task
> Reporter: Shawn Heisey
> Assignee: Erick Erickson
> Priority: Major
> Fix For: 7.4
>
> Attachments: SOLR-7887-WIP.patch, SOLR-7887-eoe-review.patch,
> SOLR-7887-eoe-review.patch, SOLR-7887.patch, SOLR-7887.patch,
> SOLR-7887.patch, SOLR-7887.patch, SOLR-7887.patch, SOLR-7887.patch,
> SOLR-7887.patch, SOLR-7887.patch, SOLR-7887.patch, SOLR-7887.patch,
> SOLR-7887.patch, SOLR-7887.patch, SOLR-7887.patch
>
>
> The logging services project has officially announced the EOL of log4j 1:
> https://blogs.apache.org/foundation/entry/apache_logging_services_project_announces
> In the official binary jetty deployment, we use use log4j 1.2 as our final
> logging destination, so the admin UI has a log watcher that actually uses
> log4j and java.util.logging classes. That will need to be extended to add
> log4j2. I think that might be the largest pain point to this upgrade.
> There is some crossover between log4j2 and slf4j. Figuring out exactly which
> jars need to be in the lib/ext directory will take some research.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
