[
https://issues.apache.org/jira/browse/SOLR-9510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16414053#comment-16414053
]
Cassandra Targett commented on SOLR-9510:
-----------------------------------------
[~mkhludnev], I took a look at the patch and changed a couple of things.
First, I changed the sections you had titled "Often Mistake" to be CAUTION
blocks instead - this separates them from the main text in a better way. I
noticed that both these sections mention what the error was in older
versions...how long ago was that? If it was more than a couple of releases,
let's remove those.
The second thing I changed was to make the {{[literal]}} blocks that included
query examples into {{[source,text]}} blocks - I did this for consistency. If
we ever decide to change how those blocks look in either HTML or PDF, these
won't be odd men out as it were. I left the other literal blocks that showed
the error since that's probably fine.
When I applied the patch, Git complained about trailing white space, so I found
around about 5 or so on the entire page (not only the section you're working
with) and I fixed all of them. So my patch has some really minor changes for
the page as a whole that aren't related to your changes - just didn't want you
to get confused.
+1 from me, thanks. If you can commit it to 7.3 before the RC gets made
(waiting on binaries), then it will be in the 7.3 Ref Guide.
> child level facet exclusions
> ----------------------------
>
> Key: SOLR-9510
> URL: https://issues.apache.org/jira/browse/SOLR-9510
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Facet Module, faceting, query parsers
> Reporter: Mikhail Khludnev
> Priority: Major
> Fix For: 7.3, master (8.0)
>
> Attachments: SOLR-9510-doc.patch, SOLR-9510-doc.patch,
> SOLR-9510.patch, SOLR_9510.patch, SOLR_9510.patch, SOLR_9510.patch,
> SOLR_9510.patch, SOLR_9510.patch, SOLR_9510.patch, SOLR_9510.patch,
> SOLR_9510.patch, SOLR_9510.patch, SOLR_9510.patch, SOLR_9510.patch,
> SOLR_9510.patch, SOLR_9510.patch, SOLR_9510.patch, SOLR_9510.patch
>
>
> h2. Challenge
> * Since SOLR-5743 achieved block join child level facets with counts roll-up
> to parents, there is a demand for filter exclusions.
> h2. Context
> * Then, it's worth to consider JSON Facets as an engine for this
> functionality rather than support a separate component.
> * During a discussion in SOLR-8998 a solution for block join with child
> level exclusion has been found.
> h2. Proposal
> It's proposed to provide a bit of syntax sugar to make it user friendly,
> believe it or not.
> h2. List of improvements
> * introducing a local parameter {{filters}} for {{{!parent}} query parser
> referring to _multiple_ filters queries via parameter name: {{{!parent
> filters=$child.fq ..}..&child.fq=color:Red&child.fq=size:XL}}
> these _filters_ are intersected with a child query supplied as a subordinate
> clause.
> * introducing \{{{!filters param=$child.fq excludeTags=color
> v=$subq}&subq=text:word&child.fq= \{!tag=color}color:Red&child.fq=size:XL}}
> it intersects a subordinate clause (here it's {{subq}} param, and the trick
> is to refer to the same query from {{{!parent}}}), with multiple filters
> supplied via parameter name {{param=$child.fq}}, it also supports
> {{excludeTags}}.
> h2. Notes
> Regarding the latter parser, the alternative approach might be to move into
> {{domain:{..}}} instruction of json facet. From the implementation
> perspective, it's desired to optimize with bitset processing, however I
> suppose it's might be deferred until some initial level of maturity.
> h2. Example
> {code:java}
> q={!parent which=type_s:book filters=$child.fq
> v=$childquery}&childquery=comment_t:good&child.fq={!tag=author}author_s:yonik&child.fq={!tag=stars}stars_i:(5
> 3)&wt=json&indent=on&json.facet={
> comments_for_author:{
> type:query,
> q:"{!filters param=$child.fq excludeTags=author v=$childquery}",
> "//note":"author filter is excluded",
> domain:{
> blockChildren:"type_s:book",
> "//":"applying filters here might be more promising"
> }, facet:{
> authors:{
> type:terms,
> field:author_s,
> facet: {
> in_books: "unique(_root_)"
> }
> }
> }
> } ,
> comments_for_stars:{
> type:query,
> q:"{!filters param=$child.fq excludeTags=stars v=$childquery}",
> "//note":"stars_i filter is excluded",
> domain:{
> blockChildren:"type_s:book"
> }, facet:{
> stars:{
> type:terms,
> field:stars_i,
> facet: {
> in_books: "unique(_root_)"
> }
> }
> }
> }
> }
> {code}
> Votes? Opinions?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
