[
https://issues.apache.org/jira/browse/SOLR-7887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16414760#comment-16414760
]
Varun Thacker commented on SOLR-7887:
-------------------------------------
Updated patch for the 2nd round of followups
- Patch merges and minor and major versions split for the log4j ivy version
file and updates the ref guide to reflect the correct url structure
- The prometheus contrib now uses log4j2.xml files ( needed for log4j2 )
instead of the older log4j.properties
Java9 precommit passes with "ant precommit -Dis.jenkins.build=true"
bq. Tomás had a comment on the reviewboard which we never addressed : "Right.
And we already have lines for forbidding 1.2 jog4j and JUL. My point is that we
need to add the new packages there. See file "solr.txt" under
lucene/tools/forbiddenApis
I'll look into that and if we need any changes I'll tackle that in a separate
Jira
bq. - To keep the behaviour of SOLR_LOG_PRESTART_ROTATION consistent ( one
could turn it off ) removed <OnStartupTriggeringPolicy /> from the default
log4j2.xml as SOLR_LOG_PRESTART_ROTATION takes care of it
Not doing this anymore after Jan's comments. Let's remove
SOLR_LOG_PRESTART_ROTATION as suggested. I'll create a separate Jira for that
so that we can call it out in the CHANGES entry explicitly
> Upgrade Solr to use log4j2 -- log4j 1 now officially end of life
> ----------------------------------------------------------------
>
> Key: SOLR-7887
> URL: https://issues.apache.org/jira/browse/SOLR-7887
> Project: Solr
> Issue Type: Task
> Reporter: Shawn Heisey
> Assignee: Erick Erickson
> Priority: Major
> Fix For: 7.4
>
> Attachments: SOLR-7887-WIP.patch, SOLR-7887-eoe-review.patch,
> SOLR-7887-eoe-review.patch, SOLR-7887-followup_1.patch, SOLR-7887.patch,
> SOLR-7887.patch, SOLR-7887.patch, SOLR-7887.patch, SOLR-7887.patch,
> SOLR-7887.patch, SOLR-7887.patch, SOLR-7887.patch, SOLR-7887.patch,
> SOLR-7887.patch, SOLR-7887.patch, SOLR-7887.patch, SOLR-7887.patch,
> SOLR-7887_followup_2.patch, SOLR-7887_followup_2.patch
>
>
> The logging services project has officially announced the EOL of log4j 1:
> https://blogs.apache.org/foundation/entry/apache_logging_services_project_announces
> In the official binary jetty deployment, we use use log4j 1.2 as our final
> logging destination, so the admin UI has a log watcher that actually uses
> log4j and java.util.logging classes. That will need to be extended to add
> log4j2. I think that might be the largest pain point to this upgrade.
> There is some crossover between log4j2 and slf4j. Figuring out exactly which
> jars need to be in the lib/ext directory will take some research.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
