-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65942/
-----------------------------------------------------------

(Updated March 28, 2018, 3:19 a.m.)


Review request for lucene.


Changes
-------

Uploading most recent patch from SOLR-11982 on behalf of Ere Maijala


Repository: lucene-solr


Description
-------

Creating this Review request on Ere Maijala's patch. See SOLR-11982 for 
previous discussion.
It would be nice to have the possibility to easily sort the shards in the 
preferred order e.g. by replica type. The attached patch adds support for 
shards.sort parameter that allows one to sort e.g. PULL and TLOG replicas first 
with ``shards.sor=replicaType:PULL|TLOG``(which would mean that NRT replicas 
wouldn't be hit with queries unless they're the only ones available) and/or to 
sort by replica location (like preferLocalShards=true but more versatile).


Diffs (updated)
-----

  solr/CHANGES.txt 4af91ea76c 
  
solr/core/src/java/org/apache/solr/handler/component/HttpShardHandlerFactory.java
 6bfd36af94 
  solr/core/src/java/org/apache/solr/util/TimeOut.java ce996f4326 
  
solr/core/src/test/org/apache/solr/handler/component/TestHttpShardHandlerFactory.java
 3ffa015a26 
  solr/solr-ref-guide/src/distributed-requests.adoc 096f632bbd 
  solr/solr-ref-guide/src/shards-and-indexing-data-in-solrcloud.adoc 81c6f86666 
  solr/solrj/src/java/org/apache/solr/common/params/ShardParams.java cbc33f41f4 
  
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudSolrClientTest.java 
e54f9ad7c6 


Diff: https://reviews.apache.org/r/65942/diff/3/

Changes: https://reviews.apache.org/r/65942/diff/2-3/


Testing
-------


Thanks,

Tomás Fernández Löbbe

Reply via email to