[
https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420322#comment-16420322
]
Bruno Roustant edited comment on SOLR-11865 at 3/30/18 9:30 AM:
----------------------------------------------------------------
10- seen.contains(id) == false.
I didn't know this Lucene practice. It explains why I see this strange
construct.
"I recommend against modifying existing lines" - that's what I tried (see
points 3,5,6 above) and I thought this "!seen.contains(id)" was tiny and
harmless. And that's a warning highlighted by IntelliJ by the way :)
was (Author: bruno.roustant):
10- seen.contains(id) == false.
I didn't know this Lucene practice. It explains why I see this strange
construct.
"I recommend against modifying existing lines" - that's what I tried (see
points 3,5,6 above) and I thought this "!seen.contains(id)" was tiny and
harmless.
> Refactor QueryElevationComponent to prepare query subset matching
> -----------------------------------------------------------------
>
> Key: SOLR-11865
> URL: https://issues.apache.org/jira/browse/SOLR-11865
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SearchComponents - other
> Affects Versions: master (8.0)
> Reporter: Bruno Roustant
> Priority: Minor
> Labels: QueryComponent
> Fix For: master (8.0)
>
> Attachments:
> 0001-Refactor-QueryElevationComponent-to-introduce-Elevat.patch,
> SOLR-11865.patch
>
>
> The goal is to prepare a second improvement to support query terms subset
> matching or query elevation rules.
> Before that, we need to refactor the QueryElevationComponent. We make it
> extendible. We introduce the ElevationProvider interface which will be
> implemented later in a second patch to support subset matching. The current
> full-query match policy becomes a default simple MapElevationProvider.
> - Add overridable methods to handle exceptions during the component
> initialization.
> - Add overridable methods to provide the default values for config properties.
> - No functional change beyond refactoring.
> - Adapt unit test.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
