[
https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420920#comment-16420920
]
David Smiley commented on SOLR-11865:
-------------------------------------
Thanks by the way for entertaining some further improvements to the code that
aren't essential. I'm aware some of my feedback is to code you didn't write.
It's spring-cleaning time :)
* splitQueryTermsWithAnalyzer: Could be improved to use try-with-resources
style since TokenStream is Closeable
* RE == false vs "!", "And that's a warning highlighted by IntelliJ by the
way": I know; IntelliJ has a ton of things it warns about in its default
configuration. It goes a bit far IMO; a default config should be very
conservative. I've tweaked my warning settings a lot (some on, some off).
* RE exceptions: I get that you want to expose more insight into what went
wrong. I'm just wondering if the stock QueryElevationComponent could be a bit
simpler complexity-wise and still accommodate your needs via another mechanism.
I like trying to simplify where possible. What if we do away with this
LoadingExceptionHandler as a separate class and instead have protected methods
directly on QueryElevationComponent?
And that's it.
> Refactor QueryElevationComponent to prepare query subset matching
> -----------------------------------------------------------------
>
> Key: SOLR-11865
> URL: https://issues.apache.org/jira/browse/SOLR-11865
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SearchComponents - other
> Affects Versions: master (8.0)
> Reporter: Bruno Roustant
> Priority: Minor
> Labels: QueryComponent
> Fix For: master (8.0)
>
> Attachments:
> 0001-Refactor-QueryElevationComponent-to-introduce-Elevat.patch,
> 0002-Refactor-QueryElevationComponent-after-review.patch, SOLR-11865.patch
>
>
> The goal is to prepare a second improvement to support query terms subset
> matching or query elevation rules.
> Before that, we need to refactor the QueryElevationComponent. We make it
> extendible. We introduce the ElevationProvider interface which will be
> implemented later in a second patch to support subset matching. The current
> full-query match policy becomes a default simple MapElevationProvider.
> - Add overridable methods to handle exceptions during the component
> initialization.
> - Add overridable methods to provide the default values for config properties.
> - No functional change beyond refactoring.
> - Adapt unit test.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
