I created SOLR-12199. -- Steve www.lucidworks.com
> On Apr 2, 2018, at 2:31 PM, Dawid Weiss <[email protected]> wrote: > > I see this in TestReplicationHandler: > > /** > * character copy of file using UTF-8. If port is non-null, will be > substituted any time "TEST_PORT" is found. > */ > private static void copyFile(File src, File dst, Integer port, > boolean internalCompression) throws IOException { > BufferedReader in = new BufferedReader(new InputStreamReader(new > FileInputStream(src), StandardCharsets.UTF_8)); > Writer out = new OutputStreamWriter(new FileOutputStream(dst), > StandardCharsets.UTF_8); > > for (String line = in.readLine(); null != line; line = in.readLine()) { > > if (null != port) > line = line.replace("TEST_PORT", port.toString()); > > So it seems port is allowed to be null and then won't be substituted. > This looks like a bug in the test scaffolding: this situation > shouldn't be allowed; if a port cannot be acquired the test should > fail much sooner? > > Dawid > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
