----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66587/#review201040 -----------------------------------------------------------
LGTM. Left some minor comments/questions solr/core/src/java/org/apache/solr/core/SolrConfig.java Lines 682 (patched) <https://reviews.apache.org/r/66587/#comment281968> I'm guessing this is also -1 solr/core/src/java/org/apache/solr/update/CommitTracker.java Lines 175-181 (patched) <https://reviews.apache.org/r/66587/#comment281969> With some bad luck we could be scheduling two commits here, rigt? solr/core/src/test/org/apache/solr/update/MaxSizeAutoCommitTest.java Lines 116 (patched) <https://reviews.apache.org/r/66587/#comment281970> Is there a way to avoid this sleep? maybe wait until there are 2 tlogs (with a timeout), or maybe use some internal IW method like `hasUncommittedChanges()`? solr/core/src/test/org/apache/solr/update/MaxSizeAutoCommitTest.java Lines 157 (patched) <https://reviews.apache.org/r/66587/#comment281971> Same as above solr/core/src/test/org/apache/solr/update/MaxSizeAutoCommitTest.java Lines 203 (patched) <https://reviews.apache.org/r/66587/#comment281972> Is this @Repeat intended to stay? - Tomás Fernández Löbbe On April 12, 2018, 2:57 p.m., Anshum Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66587/ > ----------------------------------------------------------- > > (Updated April 12, 2018, 2:57 p.m.) > > > Review request for lucene. > > > Bugs: SOLR-11277 > https://issue.apache.org/jira/browse/SOLR-11277 > > > Repository: lucene-solr > > > Description > ------- > > Posting on behalf of Rupa Shanker, who contributed this patch. > > > Diffs > ----- > > solr/core/src/java/org/apache/solr/core/SolrConfig.java 6c67645 > solr/core/src/java/org/apache/solr/update/CommitTracker.java 6cf7504 > solr/core/src/java/org/apache/solr/update/DirectUpdateHandler2.java 922419c > solr/core/src/java/org/apache/solr/update/TransactionLog.java 35d722b > solr/core/src/java/org/apache/solr/update/UpdateLog.java fbdf616 > > solr/core/src/test-files/solr/collection1/conf/bad-solrconfig-no-autocommit-tag.xml > PRE-CREATION > solr/core/src/test-files/solr/collection1/conf/solrconfig-tlog.xml c8884c6 > solr/core/src/test/org/apache/solr/core/TestConfig.java 5a7b706 > solr/core/src/test/org/apache/solr/update/MaxSizeAutoCommitTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/66587/diff/1/ > > > Testing > ------- > > Unit tests and benchmarking results on the JIRA. > > > Thanks, > > Anshum Gupta > >
