[ https://issues.apache.org/jira/browse/SOLR-10513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437511#comment-16437511 ]
ASF subversion and git services commented on SOLR-10513: -------------------------------------------------------- Commit 6d771dcc9f0c6cbb33b1b5cf6c60f126713d9555 in lucene-solr's branch refs/heads/branch_7x from jdyer1 [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6d771dc ] SOLR-10513: Implement .equals() for LuceneLevenshteinDistance. > CLONE - ConjunctionSolrSpellChecker wrong check for same string distance > ------------------------------------------------------------------------ > > Key: SOLR-10513 > URL: https://issues.apache.org/jira/browse/SOLR-10513 > Project: Solr > Issue Type: Bug > Components: spellchecker > Affects Versions: 4.9 > Reporter: Abhishek Kumar Singh > Assignee: James Dyer > Priority: Major > Fix For: 7.4 > > Attachments: SOLR-10513.patch, SOLR-10513.patch, SOLR-10513.patch, > SOLR-10513.patch, SOLR-10513.patch, SOLR-10513.patch, SOLR-10513.patch > > > See ConjunctionSolrSpellChecker.java > try { > if (stringDistance == null) { > stringDistance = checker.getStringDistance(); > } else if (stringDistance != checker.getStringDistance()) { > throw new IllegalArgumentException( > "All checkers need to use the same StringDistance."); > } > } catch (UnsupportedOperationException uoe) { > // ignore > } > In line stringDistance != checker.getStringDistance() there is comparing by > references. So if you are using 2 or more spellcheckers with same distance > algorithm, exception will be thrown anyway. > *Update:* As of Solr 6.5, this has been changed to > *stringDistance.equals(checker.getStringDistance())* . > However, *LuceneLevenshteinDistance* does not even override equals method. > This does not solve the problem yet, because the *default equals* method > anyway compares references. > Hence unable to use *FileBasedSolrSpellChecker* . > Moreover, Some check of similar sorts should also be in the init method. So > that user does not have to wait for this error during query time. If the > spellcheck components have been added *solrconfig.xml* , it should throw > error during core-reload itself. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org