Requirements for javadocs vary between Lucene and Solr (and between packages) as far as I understand it.
https://github.com/apache/lucene-solr/blob/releases/lucene-solr/7.3.0/lucene/build.xml#L156-L199 is for Lucene and there is a semi-equivalent at https://github.com/apache/lucene-solr/blob/releases/lucene-solr/7.3.0/solr/build.xml#L678 for Solr. Christine From: dev@lucene.apache.org At: 04/13/18 03:56:17To: dev@lucene.apache.org Subject: Re: Precommit failures It's happening to me too! I added a /** anything */ comment on these two methods and the warning went away. But we don't have rules about requiring comments on public methods (I thought)? On Thu, Apr 12, 2018 at 8:51 PM Erick Erickson <erickerick...@gmail.com> wrote: I'm getting this precommit failure on a fresh clone of master: -documentation-lint: [echo] checking for broken html... [jtidy] Checking for broken html (such as invalid tags)... [delete] Deleting directory /Users/Erick/apache/solrVersions/solr-12028/lucene/build/jtidy_tmp [echo] Checking for broken links... [exec] [exec] Crawl/parse... [exec] [exec] Verify... [echo] Checking for missing docs... [exec] [exec] build/docs/spatial3d/org/apache/lucene/spatial3d/geom/SidedPlane.html [exec] missing Methods: strictlyWithin-double-double-double- [exec] missing Methods: strictlyWithin-org.apache.lucene.spatial3d.geom.Vector- [exec] [exec] Missing javadocs were found! Anyone have a clue? I don't see Jenkins failures for this so maybe it's just me somehow. Erick --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org -- Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker LinkedIn: http://linkedin.com/in/davidwsmiley | Book: http://www.solrenterprisesearchserver.com
