[
https://issues.apache.org/jira/browse/SOLR-12233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16443553#comment-16443553
]
David Smiley commented on SOLR-12233:
-------------------------------------
Sorry I didn't address your comments Shawn; I read them. I've been working
with Jeff and he's been measuring this stuff, and this issue right here was a
huge chunk of time (as measured in profiling). Sure maybe disabling some
things altogether might help as well... but this is an unusual scenario to
optimize for. At least this issue seems pretty straight-forward & clean.
Making some things disable-able might not be worth whatever
maintenance/complexity in having that option; I don't know yet. It seems like
premature optimization right now.
BTW if I recall /update/csv etc. are actually still the Update request handler
but simply have the content type auto-set to the appropriate mime-type.
CSVRequestHandler doesn't exist anymore; instead those formats were moved to
ContentStreamLoader subclasses. So this isn't a good example of excess weight
to avoid.
> QParserPlugin maintains a list of classes recreated every time a Solrcore
> object is created
> -------------------------------------------------------------------------------------------
>
> Key: SOLR-12233
> URL: https://issues.apache.org/jira/browse/SOLR-12233
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Affects Versions: 7.1.1
> Reporter: Jeff Miller
> Assignee: Erick Erickson
> Priority: Minor
> Labels: Performance, qparserplugin
> Time Spent: 10m
> Remaining Estimate: 0h
>
> QParserPlugin maintains a static map of Class Names to Class objects and
> everytime we create a SolrCore object this causes a lot of overhead doing
> classloader lookups. Our system runs a lot of cores and the classloader gets
> bogged down when a lot of threads are creating solrcore objects.
> There's no need to create these objects every time, similar classes such as
> TransformerFactory store the object one time and reference it over and over
> again
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
