[ https://issues.apache.org/jira/browse/LUCENE-8272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449856#comment-16449856 ]
Simon Willnauer commented on LUCENE-8272: ----------------------------------------- [https://github.com/s1monw/lucene-solr/pull/15] /cc [~mikemccand] > Share internal DV update code between binary and numeric > -------------------------------------------------------- > > Key: LUCENE-8272 > URL: https://issues.apache.org/jira/browse/LUCENE-8272 > Project: Lucene - Core > Issue Type: Improvement > Affects Versions: 7.4, master (8.0) > Reporter: Simon Willnauer > Priority: Major > Fix For: 7.4, master (8.0) > > Attachments: LUCENE-8272.patch > > > Today we duplicate a fair portion of the internal logic to > apply updates of binary and numeric doc values. This change refactors > this non-trivial code to share the same code path and only differ in > if we provide a binary or numeric instance. This also allows us to > iterator over the updates only once rather than twice once for numeric > and once for binary fields. > > This change also subclass DocValuesIterator from > DocValuesFieldUpdates.Iterator > which allows easier consumption down the road since it now shares most of > it's > interface with DocIdSetIterator which is the main interface for this in > Lucene. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org