[ 
https://issues.apache.org/jira/browse/LUCENE-8282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456093#comment-16456093
 ] 

Simon Willnauer commented on LUCENE-8282:
-----------------------------------------

https://github.com/s1monw/lucene-solr/pull/16 /cc [~mikemccand] [~shaie] 
[~dweiss]

> Reduce boxing and unnecessary object creation in DV updates
> -----------------------------------------------------------
>
>                 Key: LUCENE-8282
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8282
>             Project: Lucene - Core
>          Issue Type: Improvement
>    Affects Versions: 7.4, master (8.0)
>            Reporter: Simon Willnauer
>            Priority: Major
>             Fix For: 7.4, master (8.0)
>
>         Attachments: LUCENE-8282.patch
>
>
> DV updates used the boxed type Long to keep API generic. Yet, the missing
> type caused a lot of code duplication, boxing and unnecessary object creation.
> This change cuts over to type safe APIs using BytesRef and long (the 
> primitive)
> In this change most of the code that is almost identical between binary and 
> numeric
> is not shared reducing the maintenance overhead and likelihood of introducing 
> bugs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to