[
https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16458293#comment-16458293
]
David Smiley commented on SOLR-12290:
-------------------------------------
Hi Mark. In SOLR-11692 [~millerjeff0] and I took care not to wrap a
closeShield in SolrDispatchFilter.doFilter when the request continues on thru
chain.doFilter (line ~367). Admittedly there isn't a test for this and I
forget precisely why it mattered.
Otherwise overall the patch looks good.
* JavabinLoader: you can now inline parseAndLoadDocs
> Improve our servlet stream closing prevention code for users and devs.
> ----------------------------------------------------------------------
>
> Key: SOLR-12290
> URL: https://issues.apache.org/jira/browse/SOLR-12290
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Mark Miller
> Assignee: Mark Miller
> Priority: Minor
> Attachments: SOLR-12290.patch, SOLR-12290.patch, SOLR-12290.patch,
> SOLR-12290.patch
>
>
> Original Summary:
> When you fetch a file for replication we close the request output stream
> after writing the file which ruins the connection for reuse.
> We can't close response output streams, we need to reuse these connections.
> If we do, clients are hit will connection problems when they try and reuse
> the connection from their pool.
> New Summary:
> At some point the above was addressed during refactoring. We should remove
> these neutered closes and review our close shield code.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
