Hi Alessandro,
Thanks for bringing these issues to light, I didn’t know about them.
I’ve seen patches take up to 18 hours prior to triggering a validation job, but
I’ve never seen one take longer than that.
For both these JIRAs, I suspect that Yetus’s partial/experimental support for
linked github pull requests is what’s blocking the patches there from being
validated: both issues have linked pull requests.
I won’t have time to investigate in the short term, but if you’re interested,
you can take a look at the script[1] that makes these decisions for the
PreCommit-Admin Jenkins job[2], which is what triggers our
PreCommit-{SOLR,LUCENE}-Build jobs. This script maintains a simple text file
with "JIRA ID,patch-id” records of tested patches[3], and all patches on both
issues are listed - here are the records I found from that file:
SOLR-12238,12921031
SOLR-12243,12921075
SOLR-12243,12920318
This means that as far as Yetus is concerned, all patches on these 2 issues
have already been validated, so there is nothing to do.
[1]
https://git-wip-us.apache.org/repos/asf?p=yetus.git;a=blob;f=precommit/jenkins/jenkins-admin.py
[2] https://builds.apache.org/job/PreCommit-Admin/
[3] https://builds.apache.org/job/PreCommit-Admin/ws/patch_tested.txt
--
Steve
www.lucidworks.com
> On May 2, 2018, at 8:16 AM, Alessandro Benedetti <[email protected]> wrote:
>
> Hi,
> I was taking a look to the way a patch is validated automatically in the Solr
> Jira,
> from the documentation[1] it seems when the patch is submitted an automated
> Jenkins job is going to run within 12 hours ( if the naming convention is
> respected ):
>
> This is the Jenkins job :
> https://builds.apache.org/job/PreCommit-SOLR-Build/
>
> I submitted 4 days ago a couple of patches :
>
> https://issues.apache.org/jira/browse/SOLR-12238 -> No Jenkins job triggered
>
> https://issues.apache.org/jira/browse/SOLR-12243 -> first patch triggered the
> Jenkins job, the second one didn't
>
> I don't have Jenkins admin rights and I have not investigated that side too
> much, as I was expecting this to "just work" .
> Have I missed anything ?
>
> Regards
>
> [1] https://wiki.apache.org/solr/HowToContribute#Generating_a_patch
> --------------------------
> Alessandro Benedetti
> Search Consultant, R&D Software Engineer, Director
>
> www.sease.io
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
