I'll push that stop condition under https://issues.apache.org/jira/browse/SOLR-12307
On Thu, May 3, 2018 at 3:26 PM, Dawid Weiss <dawid.we...@gmail.com> wrote: > I honestly don't know (don't know much about zookeeper). I think there > should be some kind of action to this unrecoverable situation rather > than an endless loop :) Your patch looks good to me, but I really > don't know much about that fragment of the code. > > Dawid > > On Thu, May 3, 2018 at 2:12 PM, Mikhail Khludnev <m...@apache.org> wrote: > > I have the fix just for this spin in > > https://issues.apache.org/jira/secure/attachment/ > 12919074/SOLR-12200.patch > > (Although I abandoned SOLR-12200) > > > > diff --git > > a/solr/core/src/java/org/apache/solr/cloud/autoscaling/ > OverseerTriggerThread.java > > b/solr/core/src/java/org/apache/solr/cloud/autoscaling/ > OverseerTriggerThread.java > > index ece4c4c..5cb1f90 100644 > > --- > > a/solr/core/src/java/org/apache/solr/cloud/autoscaling/ > OverseerTriggerThread.java > > +++ > > b/solr/core/src/java/org/apache/solr/cloud/autoscaling/ > OverseerTriggerThread.java > > @@ -142,8 +142,14 @@ public class OverseerTriggerThread implements > Runnable, > > SolrCloseable { > > Thread.currentThread().interrupt(); > > log.warn("Interrupted", e); > > break; > > - } catch (IOException | KeeperException e) { > > + } > > + catch (IOException | KeeperException e) { > > log.error("A ZK error has occurred", e); > > + if (e.getCause()!=null && e.getCause() instanceof > > KeeperException.SessionExpiredException) { > > + log.warn("Solr cannot talk to ZK, exiting " + > > + getClass().getSimpleName() + " main queue loop", e); > > + return; > > + } > > } > > } > > > > > > I can push only this, just to stop torture Jenkins. WDYT ? > > > > On Thu, May 3, 2018 at 2:57 PM, Dawid Weiss <dawid.we...@gmail.com> > wrote: > >> > >> Endless loop (session expired): > >> > >> [junit4] 2> 1992793 ERROR > >> > >> (OverseerAutoScalingTriggerThread-72097539512664067-127.0.0. > 1:8983_solr-n_0000000001) > >> [ ] o.a.s.c.a.OverseerTriggerThread A ZK error has occurre > >> d > >> [junit4] 2> java.io.IOException: > >> org.apache.zookeeper.KeeperException$SessionExpiredException: > >> KeeperErrorCode = Session expired for /autoscaling.json > >> [junit4] 2> at > >> > >> org.apache.solr.client.solrj.impl.ZkDistribStateManager. > getAutoScalingConfig(ZkDistribStateManager.java:183) > >> ~[java/:?] > >> [junit4] 2> at > >> > >> org.apache.solr.client.solrj.cloud.DistribStateManager. > getAutoScalingConfig(DistribStateManager.java:83) > >> ~[java/:?] > >> [junit4] 2> at > >> > >> org.apache.solr.cloud.autoscaling.OverseerTriggerThread.run( > OverseerTriggerThread.java:131) > >> [java/:?] > >> [junit4] 2> at java.lang.Thread.run(Thread.java:748) > >> [?:1.8.0_144] > >> [junit4] 2> Caused by: > >> org.apache.zookeeper.KeeperException$SessionExpiredException: > >> KeeperErrorCode = Session expired for /autoscaling.json > >> [junit4] 2> at > >> org.apache.zookeeper.KeeperException.create(KeeperException.java:130) > >> ~[zookeeper-3.4.11.jar:3.4.11-37e277162d567b55a07d1755f0b31c32e93c01a0] > >> [junit4] 2> at > >> org.apache.zookeeper.KeeperException.create(KeeperException.java:54) > >> ~[zookeeper-3.4.11.jar:3.4.11-37e277162d567b55a07d1755f0b31c32e93c01a0] > >> [junit4] 2> at > >> org.apache.zookeeper.ZooKeeper.getData(ZooKeeper.java:1215) > >> ~[zookeeper-3.4.11.jar:3.4.11-37e277162d567b55a07d1755f0b31c32e93c01a0] > >> [junit4] 2> at > >> > >> org.apache.solr.common.cloud.SolrZkClient.lambda$getData$5( > SolrZkClient.java:340) > >> ~[java/:?] > >> [junit4] 2> at > >> > >> org.apache.solr.common.cloud.ZkCmdExecutor.retryOperation( > ZkCmdExecutor.java:60) > >> ~[java/:?] > >> [junit4] 2> at > >> org.apache.solr.common.cloud.SolrZkClient.getData( > SolrZkClient.java:340) > >> ~[java/:?] > >> [junit4] 2> at > >> > >> org.apache.solr.client.solrj.impl.ZkDistribStateManager. > getAutoScalingConfig(ZkDistribStateManager.java:176) > >> ~[java/:?] > >> [junit4] 2> ... 3 more > >> > >> > >> On Thu, May 3, 2018 at 1:37 PM, Policeman Jenkins Server > >> <jenk...@thetaphi.de> wrote: > >> > Error processing tokens: Error while parsing action > >> > 'Text/ZeroOrMore/FirstOf/Token/DelimitedToken/DelimitedToken_Action3' > at > >> > input position (line 79, pos 4): > >> > )"} > >> > ^ > >> > > >> > java.lang.OutOfMemoryError: Java heap space > >> > > >> > > >> > --------------------------------------------------------------------- > >> > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > >> > For additional commands, e-mail: dev-h...@lucene.apache.org > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > >> For additional commands, e-mail: dev-h...@lucene.apache.org > >> > > > > > > > > -- > > Sincerely yours > > Mikhail Khludnev > -- Sincerely yours Mikhail Khludnev
