[ https://issues.apache.org/jira/browse/LUCENE-8293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463664#comment-16463664 ]
ASF subversion and git services commented on LUCENE-8293: --------------------------------------------------------- Commit 3a6f5313d6b4a23dea2030cb5d63ad522536f501 in lucene-solr's branch refs/heads/master from [~simonw] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3a6f531 ] LUCENE-8293: Ensure only hard deletes are carried over in a merge Today we carry over hard deletes based on the SegmentReaders liveDocs. This is not correct if soft-deletes are used especially with rentention policies. If a soft delete is added while a segment is merged the document might end up hard deleted in the target segment. This isn't necessarily a correctness issue but causes unnecessary writes of hard-deletes. The biggest issue here is that we assert that previously deleted documents are still deleted in the live-docs we apply and that might be violated by the retention policy. > Ensure only hard deletes are carried over in a merge > ---------------------------------------------------- > > Key: LUCENE-8293 > URL: https://issues.apache.org/jira/browse/LUCENE-8293 > Project: Lucene - Core > Issue Type: Bug > Affects Versions: 7.4, master (8.0) > Reporter: Simon Willnauer > Priority: Major > Fix For: 7.4, master (8.0) > > Attachments: LUCENE-8293.patch, LUCENE-8293.patch > > > Today we carry over hard deletes based on the SegmentReaders liveDocs. > This is not correct if soft-deletes are used especially with rentention > policies. If a soft delete is added while a segment is merged the document > might end up hard deleted in the target segment. This isn't necessarily a > correctness issue but causes unnecessary writes of hard-deletes. The > biggest > issue here is that we assert that previously deleted documents are still > deleted > in the live-docs we apply and that might be violated by the retention > policy. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org