Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/370#discussion_r186205859
--- Diff: solr/core/src/java/org/apache/solr/handler/IndexFetcher.java ---
@@ -1629,8 +1630,6 @@ private int fetchPackets(FastInputStream fis) throws
Exception {
LOG.warn("No content received for file: {}", fileName);
return NO_CONTENT;
}
- if (buf.length < packetSize)
--- End diff --
I appreciate that this check may be needless now but it feels awfully
presumptuous to me that this could never happen. Like what if PACKET_SZ
changes some day and someone is upgrading their Solr cluster with mixed
versions at the same time and a larger packet is sent? Even an assert feels to
strict. It could happen but it's not expected to. So leave it and add a
simple one-liner comment that in practice this won't happen but we adjust in
case it does.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
