[ https://issues.apache.org/jira/browse/SOLR-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468265#comment-16468265 ]
Varun Thacker commented on SOLR-11453: -------------------------------------- Hi Shawn, Thanks for working on the patch. Few things I wanted to ask you. {quote}bq. I noticed the SolrCore class has an empty top-level Javadoc. Which makes precommit pass, but doesn't give anyone any information about the class. That's a rather glaring omission IMHO. {quote} Makes sense. I'll fold this change in. {quote}In accordance with some best practices mentioned on SOLR-12286, I removed usages of "log.isXxxxEnabled()" methods. That is the idea I was most interested in telling you about. {quote} These are logging lines that would get used for every update and search request. If by any chance removing the isDebugEnabled on these creates a ton of objects then this won't be good. I'd rather be pedantic and not change it here? What do you think? {quote}One of the warnings I noticed in eclipse is that serialVersionUID was missing from an inner anonymous class, so I had eclipse add that. Also not important for this issue. {quote} Do you know if our precommit also lists this as a warning? I'm open to adding this as but was just curious? Have you had a chance to look at my patch? Do those changes look good? If yes then I'll fold these enhancements that you added and commit it tomorrow > Create separate logger for slow requests > ---------------------------------------- > > Key: SOLR-11453 > URL: https://issues.apache.org/jira/browse/SOLR-11453 > Project: Solr > Issue Type: Improvement > Components: logging > Affects Versions: 7.0.1 > Reporter: Shawn Heisey > Assignee: Shawn Heisey > Priority: Minor > Attachments: SOLR-11453.patch, SOLR-11453.patch, SOLR-11453.patch, > SOLR-11453.patch, slowlog-informational.patch > > > There is some desire on the mailing list to create a separate logfile for > slow queries. Currently it is not possible to do this cleanly, because the > WARN level used by slow query logging within the SolrCore class is also used > for other events that SolrCore can log. Those messages would be out of place > in a slow query log. They should typically stay in main solr logfile. > I propose creating a custom logger for slow queries, similar to what has been > set up for request logging. In the SolrCore class, which is > org.apache.solr.core.SolrCore, there is a special logger at > org.apache.solr.core.SolrCore.Request. This is not a real class, just a > logger which makes it possible to handle those log messages differently than > the rest of Solr's logging. I propose setting up another custom logger > within SolrCore which could be org.apache.solr.core.SolrCore.SlowRequest. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org