For build integration, I'd like to do this on the maven side. It's easier
there, and it should not matter that it's not the official build since it only
needs to be run by Jenkins which is already running the maven build any way.
~ David
On Jul 8, 2011, at 10:08 AM, Smiley, David W. wrote:
> Developers,
> Any thoughts on using FindBugs & PMD to catch more bugs in Lucene/Solr?
> Jenkins could be configured to run FindBugs & PMD analysis nightly. It would
> have helped find this:
>
> (LUCENE-3294) Some code still compares string equality instead using
> equals
>
> I am aware there are a high degree of false-positives but there are ways of
> dealing with them, such as with @SuppressWarnings("PMD") and with //NOPMD
> and for Findbugs, there is
> @edu.umd.cs.findbugs.annotations.SuppressWarnings(....) and there's a fairly
> detailed configuration file for FindBugs to really control it and to make
> exceptions. I'd also really like to see use of FindBugs concurrency
> annotations @GuardedBy, @Immutable, @NotThreadSafe, @ThreadSafe.
>
> ~ David Smiley
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
> For additional commands, e-mail: dev-h...@lucene.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
