[ https://issues.apache.org/jira/browse/LUCENE-8273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478208#comment-16478208 ]
Robert Muir commented on LUCENE-8273: ------------------------------------- {quote} In {{TestConditionalFilter}}, converted most {{CannedTokenStream}}'s to {{MockTokenizer}}'s, which causes error {{IllegalStateException: end() called in wrong state=END!}} - I'm guessing you already know about this and are working on it {quote} Good approach, TestRandomChains is rather inefficient (basically an integration test) and its best to always make the fails reproduce with simpler unit tests. > Add a ConditionalTokenFilter > ---------------------------- > > Key: LUCENE-8273 > URL: https://issues.apache.org/jira/browse/LUCENE-8273 > Project: Lucene - Core > Issue Type: New Feature > Reporter: Alan Woodward > Assignee: Alan Woodward > Priority: Major > Fix For: 7.4 > > Attachments: LUCENE-8273-2.patch, LUCENE-8273-part2-rebased.patch, > LUCENE-8273-part2.patch, LUCENE-8273-part2.patch, LUCENE-8273.patch, > LUCENE-8273.patch, LUCENE-8273.patch, LUCENE-8273.patch, LUCENE-8273.patch, > LUCENE-8273.patch, LUCENE-8273.patch, LUCENE-8273.patch > > > Spinoff of LUCENE-8265. It would be useful to be able to wrap a TokenFilter > in such a way that it could optionally be bypassed based on the current state > of the TokenStream. This could be used to, for example, only apply > WordDelimiterFilter to terms that contain hyphens. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org