refactoring of Similarity.sloppyFreq() and Similarity.scorePayload
------------------------------------------------------------------

                 Key: LUCENE-3299
                 URL: https://issues.apache.org/jira/browse/LUCENE-3299
             Project: Lucene - Java
          Issue Type: Task
          Components: core/query/scoring
            Reporter: Robert Muir
             Fix For: 4.0
         Attachments: LUCENE-3299.patch

Currently these are top-level, but they only affect the SloppyDocScorer.
So it makes more sense to put these into the SloppyDocScorer api, this gives 
you additional flexibility
(e.g. combining payloads with CSF or whatever the hell you want to do), and is 
cleaner.

Furthermore, there are the following confusing existing issues:
* scorePayload should take bytesref
* PayloadTermScorer passes a *null* byte[] array to the sim if there are no 
payloads. I don't think it should do this, and its inconsistent with 
PayloadNearQuery, which does not do this. Its an undocumented conditional you 
need to have in the scoring algorithm which we should remove.
* there is an unused constant for scorepayload (NO_DOC_ID_PROVIDED), which is a 
documented, but never used anywhere. I think we should remove this conditional 
too, because its not possible to have a payload without a docid, and we 
shouldn't be passing fake document ids (-1) to our scoring APIs anyway.


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to