[
https://issues.apache.org/jira/browse/SOLR-12419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494460#comment-16494460
]
Shawn Heisey commented on SOLR-12419:
-------------------------------------
General java coding standards say constants should be all uppercase. But a
quick check shows that this is not what we've done with our Logger objects ...
and I think it's more than a little bit of a stretch to describe the logger
object as a constant. It's static and final, but doesn't have the same role as
fields that truly can be described as constants, like Integer.MAX_VALUE.
So ... I think an all-lowercase name makes the most sense, and standardizing on
it will have a much smaller patch. A case-sensitive search for "Logger log" in
master turns up 623 matches, while a similar search for "Logger LOG" only turns
up 85. Interestingly, most of the places it's found are in solr/core, not
solr/contrib, with a few in solr/solrj.
The lowercase search did turn up a few usages in Lucene code of
java.util.Logger. That class is available in the JRE, so it doesn't violate
the "no dependency" requirement that Lucene tries to adhere to, but I still
wonder if maybe it doesn't belong there.
> standardise solr/contrib (private) logger names
> -----------------------------------------------
>
> Key: SOLR-12419
> URL: https://issues.apache.org/jira/browse/SOLR-12419
> Project: Solr
> Issue Type: Wish
> Components: logging
> Reporter: Christine Poerschke
> Priority: Minor
> Attachments: SOLR-12419.patch
>
>
> Standardise to {{log}} or {{LOG}} initially for {{solr/contrib}} code only,
> could later incrementally be extended to cover other directories too.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
