Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/395#discussion_r193216812 --- Diff: solr/core/src/java/org/apache/solr/handler/loader/JsonLoader.java --- @@ -556,82 +556,105 @@ private void parseFieldValue(SolrInputField sif) throws IOException { if (ev == JSONParser.OBJECT_START) { parseExtendedFieldValue(sif, ev); } else { - Object val = parseNormalFieldValue(ev, sif.getName()); + Object val = parseNormalFieldValue(ev, sif); sif.setValue(val); } } + private Map<String, Object> generateExtendedValueMap(int ev) throws IOException { --- End diff -- Can you please sequence the methods so this follows where it's called from so readers needn't look back up?
--- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org